fix: remove peer from stratum worker pool if send message failed(aka, disconnected) #3307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pana
changed the title
ChenxingLi
requested changes
Aug 8, 2025
Contributor
ChenxingLi
left a comment
ChenxingLi
left a comment
There was a problem hiding this comment.
I believe more complex logic is needed here, such as explicitly matching Channel Error instead of other errors, and setting the retry count through configuration rather than directly modifying the "other branch" logic.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Member
Author
|
retest this please |
1 similar comment
Member
Author
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our pow miner account this issue, when one worker is disconnected, we should remove it from worker pool, to avoid this
This change is